-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus] Standalone startup of hotstuff participant #3513
[Consensus] Standalone startup of hotstuff participant #3513
Conversation
…s://github.com/onflow/flow-go into yurii/6420-standalone-startup-hotstuff
…ine. Updated how objects are created for collection node. Fixed tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice clean up 🧹
Codecov Report
@@ Coverage Diff @@
## feature/active-pacemaker #3513 +/- ##
============================================================
- Coverage 55.79% 52.39% -3.41%
============================================================
Files 769 498 -271
Lines 71228 46130 -25098
============================================================
- Hits 39745 24171 -15574
+ Misses 28274 19865 -8409
+ Partials 3209 2094 -1115
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup. Only stylistic comments. Thanks
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
bors merge |
https://github.com/dapperlabs/flow-go/issues/6420
Context
This PR implements standalone startup of hotstuff participant separating startup from compliance engine.
Important changes