Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] Standalone startup of hotstuff participant #3513

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

durkmurder
Copy link
Member

https://github.com/dapperlabs/flow-go/issues/6420

Context

This PR implements standalone startup of hotstuff participant separating startup from compliance engine.

Important changes

  • Hotstuff participant decoupled from compliance engine, hotstuff is created before compliance core and is injected using constructor.
  • Refactored epoch factories for collection nodes to split construction of sync core and sync engine to allow injection using construction for compliance engine.

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice clean up 🧹

Base automatically changed from yurii/6424-compliance-engine-extract-interface to feature/active-pacemaker November 18, 2022 10:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #3513 (6a6b5eb) into feature/active-pacemaker (75af49b) will decrease coverage by 3.40%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           feature/active-pacemaker    #3513      +/-   ##
============================================================
- Coverage                     55.79%   52.39%   -3.41%     
============================================================
  Files                           769      498     -271     
  Lines                         71228    46130   -25098     
============================================================
- Hits                          39745    24171   -15574     
+ Misses                        28274    19865    -8409     
+ Partials                       3209     2094    -1115     
Flag Coverage Δ
unittests 52.39% <ø> (-3.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin/command_runner.go 82.12% <0.00%> (-1.12%) ⬇️
fvm/environment/contract_updater.go 66.88% <0.00%> (-0.66%) ⬇️
ledger/complete/wal/checkpointer.go 63.10% <0.00%> (-0.27%) ⬇️
engine/collection/compliance/core.go
engine/collection/compliance/engine.go
engine/collection/epochmgr/epoch_components.go
engine/consensus/compliance/core.go
engine/consensus/compliance/engine.go
engine/common/rpc/convert/validate.go
consensus/hotstuff/signature/packer.go
... and 264 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. Only stylistic comments. Thanks

engine/collection/epochmgr/factories/sync_core.go Outdated Show resolved Hide resolved
engine/collection/epochmgr/factories/sync_core.go Outdated Show resolved Hide resolved
engine/collection/compliance/engine.go Show resolved Hide resolved
durkmurder and others added 2 commits November 22, 2022 09:25
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
@durkmurder
Copy link
Member Author

bors merge

@bors bors bot merged commit b2cced0 into feature/active-pacemaker Nov 22, 2022
@bors bors bot deleted the yurii/6420-standalone-startup-hotstuff branch November 22, 2022 07:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants