[BFT Testing] Gossipsub spam test Framework - IHAVE #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomisha
changed the base branch from
master
to
yahya/6423-gossipsub-spamming-test
Codecov Report
@@ Coverage Diff @@
## master #3564 +/- ##
==========================================
- Coverage 55.35% 46.18% -9.18%
==========================================
Files 768 114 -654
Lines 70194 11664 -58530
==========================================
- Hits 38857 5387 -33470
+ Misses 28153 5970 -22183
+ Partials 3184 307 -2877
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ptPubSubAdapterConfig`
…2p/gossipsub_spammer.go Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr>
kc1116
approved these changes
Jan 6, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 6, 2023
3564: [BFT Testing] Gossipsub spam test Framework - IHAVE r=gomisha a=gomisha This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages. It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer. - initial implementation of a general purpose Spammer that will be used for future libp2p spam testing - uses recent pubsub improvements like the RPC ingress message inspector (libp2p/go-libp2p-pubsub#509) to detect received messages on the victim node ref: https://github.com/dapperlabs/flow-go/issues/6423 Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr> Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
|
Build failed:
|
kc1116
reviewed
Jan 9, 2023
kc1116
reviewed
Jan 9, 2023
…ptions()` match with `master` still failing `TestGossipSubSignatureRequirement/TestGossipSubSignatureRequirement`
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 9, 2023
3564: [BFT Testing] Gossipsub spam test Framework - IHAVE r=gomisha a=gomisha This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages. It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer. - initial implementation of a general purpose Spammer that will be used for future libp2p spam testing - uses recent pubsub improvements like the RPC ingress message inspector (libp2p/go-libp2p-pubsub#509) to detect received messages on the victim node ref: https://github.com/dapperlabs/flow-go/issues/6455 Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr> Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"Unit Tests (Modules) (insecure, install-tools, test, 3, 1)\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Framework implementation of a spam test using libp2p gossipsub IHAVE messages.
It sets up a 2 node test between a victim node and a spammer. The spammer sends a few IHAVE control messages to the victim node without being subscribed to any of the same topics. The test then checks that the victim node received all the messages from the spammer.
ref: https://github.com/dapperlabs/flow-go/issues/6455