-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Execution] Break blobservice out to own component in en builder #3613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
- Coverage 55.27% 51.34% -3.93%
==========================================
Files 755 430 -325
Lines 69189 46033 -23156
==========================================
- Hits 38241 23637 -14604
+ Misses 27807 20374 -7433
+ Partials 3141 2022 -1119
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -422,7 +433,7 @@ func (exeNode *ExecutionNode) LoadProviderEngine( | |||
node.Logger, | |||
providerMetrics, | |||
execution_data.DefaultSerializer, | |||
bs, | |||
exeNode.blobService, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a check to ensure this module has been set and is not nil
. Type system can't ensure this, so we'd better add explicit check.
bors merge |
Backports #3497 from v0.28 to master
This fixes the initialization order of the blobservice and uploaders in the execution node builder. Blobservice is needed by both the provider engine and GCP uploader, and the uploaders are also needed by the provider