Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] Break blobservice out to own component in en builder #3613

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Nov 23, 2022

Backports #3497 from v0.28 to master

This fixes the initialization order of the blobservice and uploaders in the execution node builder. Blobservice is needed by both the provider engine and GCP uploader, and the uploaders are also needed by the provider

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #3613 (942c0b8) into master (66795f2) will decrease coverage by 3.92%.
The diff coverage is 31.91%.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   55.27%   51.34%   -3.93%     
==========================================
  Files         755      430     -325     
  Lines       69189    46033   -23156     
==========================================
- Hits        38241    23637   -14604     
+ Misses      27807    20374    -7433     
+ Partials     3141     2022    -1119     
Flag Coverage Δ
unittests 51.34% <31.91%> (-3.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/execution_builder.go 0.00% <0.00%> (ø)
cmd/util/ledger/reporters/account_reporter.go 0.00% <0.00%> (ø)
fvm/environment/env.go 100.00% <ø> (ø)
fvm/environment/facade_env.go 99.51% <ø> (ø)
fvm/state/state.go 63.15% <ø> (ø)
fvm/transactionEnv.go 0.00% <ø> (-100.00%) ⬇️
engine/collection/compliance/core.go 73.70% <7.14%> (-4.02%) ⬇️
fvm/programs/invalidator.go 50.00% <11.11%> (-50.00%) ⬇️
fvm/programs/block_programs.go 33.33% <27.77%> (-8.98%) ⬇️
fvm/fvm.go 75.28% <28.57%> (+1.87%) ⬆️
... and 353 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -422,7 +433,7 @@ func (exeNode *ExecutionNode) LoadProviderEngine(
node.Logger,
providerMetrics,
execution_data.DefaultSerializer,
bs,
exeNode.blobService,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a check to ensure this module has been set and is not nil. Type system can't ensure this, so we'd better add explicit check.

@peterargue
Copy link
Contributor Author

bors merge

@bors bors bot merged commit a053d85 into master Dec 7, 2022
@bors bors bot deleted the petera/backport-en-blobservice-fix branch December 7, 2022 20:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants