Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] Remove useless condition from builder #3659

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

SaveTheRbtz
Copy link
Contributor

@SaveTheRbtz SaveTheRbtz commented Dec 3, 2022

This check is always true on the else if branch

@SaveTheRbtz SaveTheRbtz marked this pull request as ready for review December 3, 2022 05:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #3659 (83aaa53) into master (2c449af) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3659      +/-   ##
==========================================
- Coverage   55.28%   55.26%   -0.02%     
==========================================
  Files         761      761              
  Lines       69750    69750              
==========================================
- Hits        38561    38550      -11     
- Misses      28018    28027       +9     
- Partials     3171     3173       +2     
Flag Coverage Δ
unittests 55.26% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/execution_builder.go 0.00% <0.00%> (ø)
...sus/approvals/assignment_collector_statemachine.go 41.30% <0.00%> (-7.25%) ⬇️
ledger/complete/wal/checkpointer.go 63.35% <0.00%> (-0.40%) ⬇️
engine/consensus/compliance/core.go 74.60% <0.00%> (ø)
consensus/hotstuff/eventloop/event_loop.go 74.82% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SaveTheRbtz
Copy link
Contributor Author

bors merge

@bors bors bot merged commit 57a8fda into master Dec 4, 2022
@bors bors bot deleted the rbtz/executionBuilder1 branch December 4, 2022 22:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants