Fix bug in cluster block validation. #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was duplicated to before we verified existence of the reference block. This caused an empty collection with an unknown reference block to pass validition. This breaks an assumption about the cluster state and would cause an irrecoverable error to be thrown later.
jordanschalm
requested review from
yhassanzadeh13 and
vishalchangrani
as code owners
AlexHentschel
approved these changes
Dec 14, 2022
|
bors merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was duplicated to before we verified existence of the reference block. This caused an empty collection with an unknown reference block to pass validation. This breaks an assumption about the cluster state and would cause an irrecoverable error to be thrown later.