Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve verification test's error message #3752

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

pattyshack
Copy link
Contributor

When chunk verifier returns error, a placeholder signature is generated for that chunk.

@codecov-commenter
Copy link

Codecov Report

Merging #3752 (043dc5c) into master (9c5fffa) will decrease coverage by 2.50%.
The diff coverage is n/a.

❗ Current head 043dc5c differs from pull request most recent head c0b3684. Consider uploading reports for the commit c0b3684 to get more accurate results

@@            Coverage Diff             @@
##           master    #3752      +/-   ##
==========================================
- Coverage   55.31%   52.81%   -2.51%     
==========================================
  Files         769       17     -752     
  Lines       70158      943   -69215     
==========================================
- Hits        38808      498   -38310     
+ Misses      28165      391   -27774     
+ Partials     3185       54    -3131     
Flag Coverage Δ
unittests 52.81% <ø> (-2.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/bootstrap/cmd/finalize.go
model/flow/chain.go
storage/badger/my_receipts.go
fvm/transactionInvoker.go
cmd/bootstrap/cmd/name.go
utils/unittest/chain_suite.go
fvm/environment/contract_updater.go
network/p2p/scoring/invalid_peer_id_error.go
engine/verification/requester/qualifier.go
module/signature/signing_tags.go
... and 742 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

When chunk verifier returns a chunk fault/error, a placeholder signature is
generated for that chunk.
@pattyshack pattyshack force-pushed the patrick/verification-test-err-msg branch from c0b3684 to e08ea68 Compare December 22, 2022 18:12
@pattyshack
Copy link
Contributor Author

bors merge

@bors bors bot merged commit 41682d2 into master Jan 3, 2023
@bors bors bot deleted the patrick/verification-test-err-msg branch January 3, 2023 18:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants