[Benchmark] Prevent PID windup at start #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaveTheRbtz
force-pushed
the
rbtz/preventWindup
branch
from
a441541
to
862d3f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
- Coverage 55.37% 48.17% -7.20%
==========================================
Files 769 398 -371
Lines 70251 33934 -36317
==========================================
- Hits 38902 16348 -22554
+ Misses 28161 16256 -11905
+ Partials 3188 1330 -1858
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gomisha
reviewed
Dec 22, 2022
| @@ -76,6 +77,14 @@ func NewTPSAdjuster( | |||
| go func() { | |||
| defer close(a.done) | |||
|
|
|||
| log.Info().Dur("delayInMS", params.Delay).Msg("Waiting before starting TPS adjuster") | |||
There was a problem hiding this comment.
I like this idea to inform the user there's going to be a delay.
gomisha
approved these changes
Dec 22, 2022
pattyshack
approved these changes
Dec 23, 2022
|
bors merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions in-progress are very inertial. To prevent the initial windup let's delay TPS adjustment by a couple of minutes.