Remove RecordSpanFromParent from general tracing api

[pattyshack]

The record span logic is moved into fvm's program logger (It's only used for cadence tracing)

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 8efd216

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/convert_int_to_string-2	30.2ms ± 3%	31.1ms ± 2%	+2.86%	(p=0.009 n=6+6)
RuntimeTransaction/reference_tx-2	29.5ms ± 5%	28.9ms ± 4%	~	(p=0.138 n=7+6)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	31.9ms ± 2%	34.1ms ±16%	~	(p=0.051 n=6+7)
RuntimeTransaction/get_signer_address-2	29.5ms ± 3%	29.8ms ± 3%	~	(p=0.310 n=6+6)
RuntimeTransaction/get_public_account-2	32.2ms ± 4%	32.0ms ± 5%	~	(p=0.731 n=7+6)
RuntimeTransaction/get_account_and_get_balance-2	259ms ± 2%	261ms ± 2%	~	(p=0.259 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	235ms ± 1%	238ms ± 1%	~	(p=0.053 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	34.3ms ± 3%	33.9ms ± 5%	~	(p=0.456 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	213ms ± 1%	213ms ± 3%	~	(p=0.836 n=6+7)
RuntimeTransaction/get_signer_vault-2	36.1ms ± 4%	36.1ms ± 3%	~	(p=0.710 n=7+7)
RuntimeTransaction/get_signer_receiver-2	47.0ms ± 5%	46.2ms ± 3%	~	(p=0.209 n=7+7)
RuntimeTransaction/transfer_tokens-2	189ms ± 2%	188ms ± 2%	~	(p=0.620 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	35.4ms ± 2%	35.7ms ± 1%	~	(p=0.318 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	76.0ms ± 6%	76.2ms ± 3%	~	(p=0.805 n=7+7)
RuntimeTransaction/create_new_account-2	802ms ± 2%	801ms ± 0%	~	(p=0.432 n=7+5)
RuntimeTransaction/call_empty_contract_function-2	32.2ms ± 2%	32.7ms ± 5%	~	(p=0.620 n=7+7)
RuntimeTransaction/emit_event-2	47.2ms ± 4%	46.1ms ± 5%	~	(p=0.456 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	128ms ± 3%	127ms ± 2%	~	(p=0.209 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	126ms ± 2%	127ms ± 2%	~	(p=0.805 n=7+7)
RuntimeNFTBatchTransfer-2	115ms ± 3%	115ms ± 5%	~	(p=0.710 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.29s ± 1%	4.28s ± 1%	~	(p=0.383 n=7+7)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	3.10k ± 0%	3.10k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.70k ± 0%	1.70k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	24.3M ± 0%	24.3M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.64M ± 0%	5.64M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.64M ± 0%	5.64M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	334k ± 0%	334k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	12.3M ± 0%	12.3M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	331k ± 0%	331k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	336k ± 0%	336k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	336k ± 0%	336k ± 0%	~	(all equal)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_account_and_get_available_balance-2	104MB ± 3%	107MB ± 1%	+2.97%	(p=0.001 n=7+6)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	35.2MB ± 1%	35.7MB ± 1%	+1.58%	(p=0.007 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.20GB ± 0%	1.21GB ± 1%	+0.66%	(p=0.026 n=7+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	34.9MB ± 3%	34.5MB ± 2%	~	(p=0.383 n=7+7)
RuntimeTransaction/convert_int_to_string-2	34.7MB ± 0%	35.4MB ± 2%	~	(p=0.149 n=5+7)
RuntimeTransaction/get_signer_address-2	35.0MB ± 1%	35.3MB ± 1%	~	(p=0.138 n=6+7)
RuntimeTransaction/get_public_account-2	36.2MB ± 4%	36.7MB ± 2%	~	(p=0.534 n=7+6)
RuntimeTransaction/get_account_and_get_balance-2	120MB ± 3%	122MB ± 1%	~	(p=0.128 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	36.8MB ± 3%	36.6MB ± 5%	~	(p=0.805 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	103MB ± 0%	103MB ± 0%	~	(p=0.151 n=5+5)
RuntimeTransaction/get_signer_vault-2	36.5MB ± 4%	36.2MB ± 2%	~	(p=0.456 n=7+7)
RuntimeTransaction/get_signer_receiver-2	41.1MB ± 5%	40.4MB ± 2%	~	(p=0.456 n=7+7)
RuntimeTransaction/transfer_tokens-2	83.5MB ± 4%	83.6MB ± 3%	~	(p=1.000 n=7+6)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	36.1MB ± 3%	35.9MB ± 1%	~	(p=0.628 n=6+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	51.6MB ± 2%	52.8MB ± 4%	~	(p=0.234 n=6+7)
RuntimeTransaction/create_new_account-2	182MB ± 3%	182MB ± 3%	~	(p=0.805 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	35.6MB ± 3%	35.9MB ± 3%	~	(p=0.383 n=7+7)
RuntimeTransaction/emit_event-2	41.0MB ± 3%	40.3MB ± 5%	~	(p=0.445 n=6+7)
RuntimeTransaction/borrow_array_from_storage-2	70.5MB ± 4%	69.5MB ± 3%	~	(p=0.209 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	81.4MB ± 3%	81.7MB ± 1%	~	(p=0.383 n=7+7)
RuntimeNFTBatchTransfer-2	53.9MB ± 2%	53.7MB ± 4%	~	(p=0.805 n=7+7)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	82.4k ± 0%	82.7k ± 0%	+0.41%	(p=0.001 n=7+7)
RuntimeTransaction/get_signer_address-2	86.5k ± 0%	86.9k ± 0%	+0.40%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.10M ± 0%	1.11M ± 0%	+0.39%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string-2	94.5k ± 0%	94.9k ± 0%	+0.37%	(p=0.001 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	97.8k ± 0%	98.2k ± 0%	+0.36%	(p=0.001 n=7+6)
RuntimeTransaction/get_account_and_get_available_balance-2	1.23M ± 0%	1.23M ± 0%	+0.35%	(p=0.001 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2	1.30M ± 0%	1.30M ± 0%	+0.33%	(p=0.001 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	106k ± 0%	106k ± 0%	+0.32%	(p=0.001 n=6+7)
RuntimeTransaction/get_public_account-2	109k ± 0%	109k ± 0%	+0.31%	(p=0.001 n=7+6)
RuntimeTransaction/get_account_and_get_storage_used-2	119k ± 0%	119k ± 0%	+0.29%	(p=0.001 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	121k ± 0%	122k ± 0%	+0.28%	(p=0.001 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	17.2M ± 0%	17.2M ± 0%	+0.28%	(p=0.001 n=7+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_signer_vault-2	123k ± 0%	123k ± 0%	+0.28%	(p=0.003 n=7+5)
RuntimeTransaction/emit_event-2	137k ± 0%	138k ± 0%	+0.23%	(p=0.001 n=6+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	193k ± 0%	194k ± 0%	+0.18%	(p=0.001 n=7+6)
RuntimeTransaction/get_signer_receiver-2	197k ± 0%	198k ± 0%	+0.17%	(p=0.001 n=7+7)
RuntimeNFTBatchTransfer-2	268k ± 0%	268k ± 0%	+0.14%	(p=0.004 n=6+5)
RuntimeTransaction/copy_array_from_storage-2	292k ± 0%	292k ± 0%	+0.11%	(p=0.001 n=7+7)
RuntimeTransaction/create_new_account-2	2.27M ± 0%	2.27M ± 0%	+0.11%	(p=0.004 n=5+6)
RuntimeTransaction/borrow_array_from_storage-2	336k ± 0%	336k ± 0%	+0.10%	(p=0.001 n=7+7)
RuntimeTransaction/transfer_tokens-2	842k ± 0%	842k ± 0%	+0.04%	(p=0.001 n=7+7)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.09k ± 1%	2.09k ± 1%	~	(p=0.383 n=7+7)

[pattyshack]

bors merge

[bors]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)