[CI] Remove --ssh flag from docker build for util #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #3798 +/- ##
=======================================
Coverage 55.36% 55.36%
=======================================
Files 769 769
Lines 70431 70431
=======================================
Hits 38997 38997
- Misses 28258 28259 +1
+ Partials 3176 3175 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sjonpaulbrown
approved these changes
Jan 12, 2023
|
bors merge |
peterargue
added a commit
that referenced
this pull request
Jan 12, 2023
3798: [CI] Remove --ssh flag from docker build for util r=peterargue a=peterargue The `--ssh default` flag is only needed for building when the repo contains a dependency within a private repo. This is generally not needed so removing. Running with this flag causes CI builds to fail: https://github.com/onflow/flow-go/actions/runs/3896458835/jobs/6653020995 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
added a commit
that referenced
this pull request
Jan 12, 2023
3798: [CI] Remove --ssh flag from docker build for util r=peterargue a=peterargue The `--ssh default` flag is only needed for building when the repo contains a dependency within a private repo. This is generally not needed so removing. Running with this flag causes CI builds to fail: https://github.com/onflow/flow-go/actions/runs/3896458835/jobs/6653020995 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
This was referenced Jan 12, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--ssh defaultflag is only needed for building when the repo contains a dependency within a private repo. This is generally not needed so removing.Running with this flag causes CI builds to fail: https://github.com/onflow/flow-go/actions/runs/3896458835/jobs/6653020995