Re-enable Epoch Integration Tests #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously failure to retrieve finalized block would log an error but continue, causing a nil ptr exception.
Codecov Report
@@ Coverage Diff @@
## feature/active-pacemaker #3835 +/- ##
============================================================
- Coverage 53.51% 44.53% -8.98%
============================================================
Files 812 223 -589
Lines 76585 25261 -51324
============================================================
- Hits 40984 11251 -29733
+ Misses 32307 12999 -19308
+ Partials 3294 1011 -2283
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
(we should look at splitting these out into separate jobs, but this will show whether test changes are working)
Previously ANs joining with non-spork-root snapshot would skip ingesting first 600 block's collection, to ensure they could resolve all reference blocks. That has been replaced by ensuring the initial snapshot itself has enough history to resolve all reference blocks for all ingested blocks after the root block
(which will create and setup staking account all in one shot)
* remove unused functions, add link to commit where they can be found again if needed
jordanschalm
commented
Jan 24, 2023
jordanschalm
commented
Jan 24, 2023
jordanschalm
requested review from
vishalchangrani,
AlexHentschel and
durkmurder
as code owners
AlexHentschel
approved these changes
Jan 25, 2023
| sdktemplates "github.com/onflow/flow-go-sdk/templates" | ||
| "github.com/onflow/flow-go/model/flow" | ||
| ) | ||
|
|
||
| //go:embed templates/create-and-setup-node.cdc |
There was a problem hiding this comment.
cool, didn't know about go:embed; very handy
|
bors merge |
This was referenced Jan 26, 2023
bors bot
added a commit
that referenced
this pull request
Jan 30, 2023
3869: Sync `feature/active-pacemaker` with `v0.29` r=jordanschalm a=jordanschalm Sync `feature/active-pacemaker` with `v0.29` Adds 2 PRs: - #3859 - #3835 Additional commit resolves merge conflicts: - 0ba6366 Co-authored-by: Jordan Schalm <jordan@dapperlabs.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Jan 30, 2023
3869: Sync `feature/active-pacemaker` with `v0.29` r=jordanschalm a=jordanschalm Sync `feature/active-pacemaker` with `v0.29` Adds 2 PRs: - #3859 - #3835 Additional commit resolves merge conflicts: - 0ba6366 Co-authored-by: Jordan Schalm <jordan@dapperlabs.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables all epoch integration tests, reduces time taken by epoch integration tests by about 30%, and fixes a bug in the snapshot validator function.
Test Speed Notes
Local
Before improvements, was 650-720s.
After improvements, is 400-430s
CI
Before improvements, was 30-40m
After improvements, is ~23m