[Access] Fix panic converting execution data to protobuf messages #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3887: [Access] Fix panic converting execution data to protobuf messages r=peterargue a=peterargue This PR fixes a panic in the state stream API when handling an execution data for a block with an empty service chunk. It also relaxes validation of transactions from execution data to handle service transactions. Finally, it introduces a new method `execution_data.CalculateID()` which allows you to calculate the execution data id from a `BlockExecutionData`. This enables consumers of the state stream API to verify the data they receives matches the data included in the sealed `ExecutionResult` Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## v0.29 #3892 +/- ##
==========================================
- Coverage 53.47% 53.41% -0.06%
==========================================
Files 812 813 +1
Lines 76105 76180 +75
==========================================
Hits 40695 40695
- Misses 32113 32178 +65
- Partials 3297 3307 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lolpuddle
approved these changes
Feb 2, 2023
koko1123
approved these changes
Feb 2, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3887