Fix printing trie hash #3926
Merged
Fix printing trie hash #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Feb 11, 2023
| @@ -94,9 +94,9 @@ func (mt *MTrie) RootNode() *node.Node { | |||
| // Concurrency safe (as Tries are immutable structures by convention) | |||
| func (mt *MTrie) String() string { | |||
| if mt.IsEmpty() { | |||
| return fmt.Sprintf("Empty Trie with default root hash: %x\n", mt.RootHash()) | |||
| return fmt.Sprintf("Empty Trie with default root hash: %v\n", mt.RootHash()) | |||
There was a problem hiding this comment.
RootHash() returns hash.Hash, which has implemented String method already, using %x would double encoding.
For instance,
Before the fix, it prints:
Empty Trie with default root hash: 35363866346563373430666533623564653838303334636237623166626464623431353438623036386633316165626338616539313839653432396335373439
After the fix, it prints:
Empty Trie with default root hash: 568f4ec740fe3b5de88034cb7b1fbddb41548b068f31aebc8ae9189e429c5749
zhangchiqing
requested review from
ramtinms,
m4ksio and
AlexHentschel
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3926 +/- ##
=======================================
Coverage 53.32% 53.32%
=======================================
Files 819 819
Lines 76764 76764
=======================================
+ Hits 40935 40937 +2
+ Misses 32516 32514 -2
Partials 3313 3313
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pattyshack
approved these changes
Feb 13, 2023
fxamacker
approved these changes
Feb 13, 2023
|
bors merge |
|
Build failed: |
|
bors retry |
|
Build failed:
|
|
bors retry |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.