[v0.29] Remove requirement that weight > 0 in EpochSetup validation

[jordanschalm]

Backport of #3934

This PR removes the requirement that included nodes have non-zero weight, from EpochSetup service event validation.

This requirement, in combination with a Staking contract bug, caused EECC to be triggered on Mainnet Feb 15.

Service event validation is intended to ensure that service events contain valid data. Although it was largely working as designed in this case (a service event which had unexpected data due to a bug in the smart contract was rejected), since the protocol state does correctly handle nodes with zero weight already, removing this requirement will safely prevent any similar smart contract problem from triggering EECC in the future.

[codecov-commenter]

Codecov Report

Merging #3935 (9799ea8) into v0.29 (94348de) will decrease coverage by 2.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.29    #3935      +/-   ##
==========================================
- Coverage   53.45%   51.22%   -2.23%     
==========================================
  Files         813      658     -155     
  Lines       76189    58591   -17598     
==========================================
- Hits        40726    30013   -10713     
+ Misses      32159    26147    -6012     
+ Partials     3304     2431     -873     

Flag	Coverage Δ
unittests	51.22% <ø> (-2.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
state/protocol/badger/validity.go	53.58% <ø> (-0.70%)	⬇️
...s/hotstuff/timeoutaggregator/timeout_collectors.go	76.11% <0.00%> (-5.98%)	⬇️
...s/hotstuff/votecollector/staking_vote_processor.go	82.35% <0.00%> (-2.95%)	⬇️
fvm/environment/contract_updater.go	66.88% <0.00%> (-0.66%)	⬇️
engine/access/rest/middleware/request_attribute.go
engine/collection/message_hub/message_hub.go
engine/consensus/approvals/approval_collector.go
engine/execution/computation/committer/noop.go
...ngine/execution/computation/committer/committer.go
engine/collection/compliance/engine.go
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jordanschalm]

bors merge

[bors]

Build succeeded:

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)