Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to public Cadence v0.31.5 #3958

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Switch to public Cadence v0.31.5 #3958

merged 1 commit into from
Feb 23, 2023

Conversation

turbolent
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #3958 (bf323e2) into v0.29 (e644427) will decrease coverage by 2.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.29    #3958      +/-   ##
==========================================
- Coverage   53.29%   51.10%   -2.19%     
==========================================
  Files         818      659     -159     
  Lines       76455    58751   -17704     
==========================================
- Hits        40745    30024   -10721     
+ Misses      32401    26296    -6105     
+ Partials     3309     2431     -878     
Flag Coverage Δ
unittests 51.10% <ø> (-2.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/hotstuff/votecollector/staking_vote_processor.go 82.35% <0.00%> (-2.95%) ⬇️
...sus/hotstuff/timeoutcollector/timeout_processor.go 85.62% <0.00%> (-1.80%) ⬇️
state/protocol/badger/validity.go 52.45% <0.00%> (-1.14%) ⬇️
fvm/environment/contract_updater.go 66.88% <0.00%> (ø)
engine/consensus/dkg/reactor_engine.go
engine/access/rest/request/get_account.go
engine/consensus/sealing/core.go
engine/unit.go
engine/access/state_stream/engine.go
engine/access/rest/util/select_filter.go
... and 155 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:v0.29 commit b5c9228

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

@peterargue peterargue merged commit 36bd091 into v0.29 Feb 23, 2023
@peterargue peterargue deleted the bastian/cadence-v0.31.5 branch February 23, 2023 01:07
bors bot added a commit that referenced this pull request Feb 25, 2023
3959: Update to Cadence v0.31.5 r=turbolent a=turbolent

Port of #3958 to master

Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot added a commit that referenced this pull request Feb 25, 2023
3959: Update to Cadence v0.31.5 r=turbolent a=turbolent

Port of #3958 to master

Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot added a commit that referenced this pull request Feb 25, 2023
3959: Update to Cadence v0.31.5 r=turbolent a=turbolent

Port of #3958 to master

Co-authored-by: Bastian Müller <bastian@axiomzen.co>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants