[Crypto] Pairing edge case #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tarakby
commented
Mar 1, 2023
tarakby
commented
- Relic multi-pairing computation has a bug in a specific edge case, that can be triggered by BLS private keys equal to 1 or -1 during signature verification. This PR introduces a temporary fix in Flow crypto while Relic gets fixed.
- add tests in the crypto lib to check the edge case.
tarakby
requested review from
AlexHentschel,
durkmurder,
jordanschalm and
peterargue
Codecov Report
@@ Coverage Diff @@
## master #3977 +/- ##
=======================================
Coverage 53.26% 53.26%
=======================================
Files 820 820
Lines 76631 76631
=======================================
+ Hits 40815 40816 +1
+ Misses 32513 32512 -1
Partials 3303 3303
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
durkmurder
reviewed
Mar 2, 2023
durkmurder
reviewed
Mar 2, 2023
| @@ -153,6 +153,10 @@ func testKeyGenSeed(t *testing.T, salg SigningAlgorithm, minLen int, maxLen int) | |||
| }) | |||
| } | |||
|
|
|||
| var BLS12381Order = []byte{0x73, 0xED, 0xA7, 0x53, 0x29, 0x9D, 0x7D, 0x48, 0x33, 0x39, | |||
There was a problem hiding this comment.
Suggested change
| var BLS12381Order = []byte{0x73, 0xED, 0xA7, 0x53, 0x29, 0x9D, 0x7D, 0x48, 0x33, 0x39, | |
| const BLS12381Order = []byte{0x73, 0xED, 0xA7, 0x53, 0x29, 0x9D, 0x7D, 0x48, 0x33, 0x39, |
There was a problem hiding this comment.
I don't think it's possible to declare an array as a constant, an array in Go cannot be immutable.
jordanschalm
approved these changes
Mar 3, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 3, 2023
3977: [Crypto] Pairing edge case r=tarakby a=tarakby - Relic multi-pairing computation has a bug in a specific edge case, that can be triggered by BLS private keys equal to 1 or -1 during signature verification. This PR introduces a temporary fix in Flow crypto while Relic gets fixed. - add tests in the crypto lib to check the edge case. Co-authored-by: Tarak Ben Youssef <tarak.benyoussef@dapperlabs.com> Co-authored-by: Tarak Ben Youssef <50252200+tarakby@users.noreply.github.com>
…nto tarak/pairing-edge-case
|
Canceled. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 21, 2023
4113: [Crypto] update Relic Version r=tarakby a=tarakby - update Relic to a version that fixes a pairing computation bug - remove the temporary fix in BLS verification (introduced in #3977) - integrate Relic's cmake and minor header changes Co-authored-by: Tarak Ben Youssef <tarak.benyoussef@dapperlabs.com> Co-authored-by: Tarak Ben Youssef <50252200+tarakby@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.