Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize CI tests #4055

Merged
merged 3 commits into from
Mar 21, 2023
Merged

optimize CI tests #4055

merged 3 commits into from
Mar 21, 2023

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Mar 16, 2023

When retrying tests, the setup phases are also retried which slows downs the overall jobs. Setup includes installing tools and building relic lib. This PR separates the setup phase from running the actual tests. The setup steps won't be retried if the tests fail.

Test jobs updated:

  • unit-test
  • unit-test-modules

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #4055 (d89dbdd) into master (43940fd) will increase coverage by 5.45%.
The diff coverage is 74.67%.

@@            Coverage Diff             @@
##           master    #4055      +/-   ##
==========================================
+ Coverage   51.13%   56.58%   +5.45%     
==========================================
  Files         600      542      -58     
  Lines       60393    46783   -13610     
==========================================
- Hits        30879    26471    -4408     
+ Misses      27052    18239    -8813     
+ Partials     2462     2073     -389     
Flag Coverage Δ
unittests 56.58% <74.67%> (+5.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/access/rpc/backend/backend.go 75.47% <0.00%> (ø)
engine/access/rpc/backend/backend_block_headers.go 24.61% <0.00%> (-6.76%) ⬇️
engine/access/rpc/backend/backend_network.go 42.02% <0.00%> (-2.59%) ⬇️
engine/access/rpc/backend/errors.go 0.00% <0.00%> (ø)
engine/collection/rpc/engine.go 11.68% <0.00%> (-0.48%) ⬇️
engine/execution/computation/committer/noop.go 0.00% <0.00%> (ø)
engine/execution/ingestion/engine.go 51.87% <0.00%> (-1.88%) ⬇️
engine/execution/rpc/engine.go 51.08% <0.00%> (-0.42%) ⬇️
model/convert/service_event.go 48.18% <ø> (ø)
model/flow/slashable.go 0.00% <ø> (ø)
... and 26 more

... and 403 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tarakby tarakby changed the title [WIP] optimize CI tests optimize CI tests Mar 16, 2023
@tarakby tarakby marked this pull request as ready for review March 16, 2023 19:42
@tarakby tarakby requested a review from gomisha as a code owner March 16, 2023 19:42
Copy link
Contributor

@gomisha gomisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work in splitting up test setup from test running.

@tarakby
Copy link
Contributor Author

tarakby commented Mar 21, 2023

bors merge

@bors bors bot merged commit b0bb651 into master Mar 21, 2023
@bors bors bot deleted the tarak/optimize-ci-setup branch March 21, 2023 01:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants