-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BN2] Update benchnet2 automation #4057
Merged
haroldsphinx
merged 14 commits into
master
from
haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart
Mar 29, 2023
Merged
[BN2] Update benchnet2 automation #4057
haroldsphinx
merged 14 commits into
master
from
haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
…ion-and-helmchart
gomisha
changed the title
Update benchnet2 automation
[BN2] Update benchnet2 automation
Mar 20, 2023
rmtodd618
approved these changes
Mar 20, 2023
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
…hart' of github.com:onflow/flow-go into haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart
Codecov Report
@@ Coverage Diff @@
## master #4057 +/- ##
==========================================
+ Coverage 51.13% 53.52% +2.39%
==========================================
Files 600 834 +234
Lines 60393 78018 +17625
==========================================
+ Hits 30879 41763 +10884
- Misses 27052 32910 +5858
- Partials 2462 3345 +883
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 257 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
Update automation to fully handle prefixing
moved PROJECT_NAME to init target, added validate pre-requisite for k8s-pod-health target
sjonpaulbrown
approved these changes
Mar 28, 2023
gomisha
approved these changes
Mar 28, 2023
…ion-and-helmchart
haroldsphinx
deleted the
haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart
branch
March 29, 2023 16:38
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a technical issue related to granting access control to dynamically generated namespaces using Helm. The primary challenge we faced was assigning access to namespaces that did not yet exist within Kubernetes. After careful review, we have determined that we can create unique services using the commit or project_name, which will allow for node-to-node routing and bootstrapping to work as expected without the need for a new namespace for each ephemeral network.
This solution will not only address the original access control issue, but it will also simplify our bootstrapping process and improve resource management by deploying resources to the same namespace. To ensure ease of use for other developers, we will also document how to query for a specific set of resources managed by Helm.
https://github.com/dapperlabs/dapper-flow-hosting/issues/1152