Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BN2] Update benchnet2 automation #4057

Merged

Conversation

haroldsphinx
Copy link
Contributor

This PR addresses a technical issue related to granting access control to dynamically generated namespaces using Helm. The primary challenge we faced was assigning access to namespaces that did not yet exist within Kubernetes. After careful review, we have determined that we can create unique services using the commit or project_name, which will allow for node-to-node routing and bootstrapping to work as expected without the need for a new namespace for each ephemeral network.

This solution will not only address the original access control issue, but it will also simplify our bootstrapping process and improve resource management by deploying resources to the same namespace. To ensure ease of use for other developers, we will also document how to query for a specific set of resources managed by Helm.

https://github.com/dapperlabs/dapper-flow-hosting/issues/1152

Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
@haroldsphinx haroldsphinx self-assigned this Mar 20, 2023
@haroldsphinx haroldsphinx marked this pull request as ready for review March 20, 2023 09:37
@gomisha gomisha changed the title Update benchnet2 automation [BN2] Update benchnet2 automation Mar 20, 2023
Signed-off-by: haroldsphinx <adedayoakinpelu@gmail.com>
…hart' of github.com:onflow/flow-go into haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #4057 (bd80179) into master (43940fd) will increase coverage by 2.39%.
The diff coverage is 67.28%.

@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
+ Coverage   51.13%   53.52%   +2.39%     
==========================================
  Files         600      834     +234     
  Lines       60393    78018   +17625     
==========================================
+ Hits        30879    41763   +10884     
- Misses      27052    32910    +5858     
- Partials     2462     3345     +883     
Flag Coverage Δ
unittests 53.52% <67.28%> (+2.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/execution_builder.go 0.00% <0.00%> (ø)
cmd/execution_config.go 0.00% <0.00%> (ø)
cmd/scaffold.go 15.07% <0.00%> (-0.20%) ⬇️
cmd/util/ledger/reporters/account_reporter.go 0.00% <0.00%> (ø)
engine/access/rpc/backend/backend.go 75.47% <0.00%> (ø)
engine/access/rpc/backend/backend_block_headers.go 24.61% <0.00%> (-6.76%) ⬇️
engine/access/rpc/backend/backend_network.go 42.02% <0.00%> (-2.59%) ⬇️
engine/access/rpc/backend/errors.go 0.00% <0.00%> (ø)
engine/collection/rpc/engine.go 11.68% <0.00%> (-0.48%) ⬇️
engine/common/provider/engine.go 77.57% <ø> (-0.11%) ⬇️
... and 78 more

... and 257 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haroldsphinx haroldsphinx merged commit 964a4f9 into master Mar 29, 2023
@haroldsphinx haroldsphinx deleted the haroldsphinx/1152-Update-Benchnet2-automation-and-helmchart branch March 29, 2023 16:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants