Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Committee] Fallback mechanism for DecodeSignerIDs #4063

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

durkmurder
Copy link
Member

This PR attempts to fix error which happens on mainnet:

$ flow blocks get 47169688 -n mainnet 
:x: Command Error: error fetching block: client: rpc error: code = Unknown desc = could not retrieve identities for block 424d4016debbab47e5feeeda3f63957d8f559d413dae28510cb7950a1ea53b46 with QC view 0: by-view query for unknown epoch

When requesting blocks from old epoch(not previous or current) we end up calling IdentitiesByEpoch which relies on local cache, and this cache doesn't have that epoch. This is the reason why getting an old block fails.
Proposed hot-fix is to use IdentitiesByBlock as fallback if the primary path has failed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #4063 (39bb40e) into v0.29 (757143d) will decrease coverage by 3.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.29    #4063      +/-   ##
==========================================
- Coverage   52.40%   49.25%   -3.16%     
==========================================
  Files         757      531     -226     
  Lines       71468    50059   -21409     
==========================================
- Hits        37455    24657   -12798     
+ Misses      30919    23277    -7642     
+ Partials     3094     2125     -969     
Flag Coverage Δ
unittests 49.25% <ø> (-3.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 229 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @durkmurder!

@peterargue peterargue merged commit 47858e0 into v0.29 Mar 21, 2023
@peterargue peterargue deleted the yurii/decode-signer-ids-by-block-id-fallback branch March 21, 2023 17:54
bors bot added a commit that referenced this pull request Mar 24, 2023
4086: Port #4063 to master r=jordanschalm a=jordanschalm

- Ports #4063 to `master`
- Adds additional documentation of the issue, and a link to an issue 7364a43

Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com>
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants