-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Only run jobs for selected roles #4075
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4075 +/- ##
==========================================
- Coverage 53.49% 51.12% -2.37%
==========================================
Files 831 669 -162
Lines 77720 59929 -17791
==========================================
- Hits 41575 30640 -10935
+ Misses 32816 26833 -5983
+ Partials 3329 2456 -873
Flags with carried forward coverage won't be shown. Click here to find out more. see 172 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
If we were to shift the build selected step in a job, we could streamline this and remove the need for the conditional This would ensure that jobs are only executed for roles that are to be built. It would "cleanup" the execution so that unnecessary jobs are not displayed in the workflow execution, and it would remove the complexity of the conditional statements. Here is a StackOverflow post for a reference of "dynamic" matrix values from a previous job. |
bors merge |
The original version would spawn jobs and do all of the pre-build steps for all roles, wasting runner resources. This change: