Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Enable execution sync by default #4159

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

peterargue
Copy link
Contributor

This modifies the default config for Access nodes to enable execution sync by default.

Operators are advised to add a flag to specify the directory where the data should be stored. e.g.

--execution-data-dir=/data/execution_data

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #4159 (af51ee5) into master (425675f) will decrease coverage by 2.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4159      +/-   ##
==========================================
- Coverage   53.48%   51.09%   -2.40%     
==========================================
  Files         837      674     -163     
  Lines       78447    60522   -17925     
==========================================
- Hits        41957    30921   -11036     
+ Misses      33135    27119    -6016     
+ Partials     3355     2482     -873     
Flag Coverage Δ
unittests 51.09% <ø> (-2.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 167 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterargue
Copy link
Contributor Author

bors merge

@bors bors bot merged commit 5b32e36 into master Apr 6, 2023
@bors bors bot deleted the petera/enable-execution-sync-default branch April 6, 2023 21:13
peterargue added a commit that referenced this pull request Apr 11, 2023
4159: [Access] Enable execution sync by default r=peterargue a=peterargue

This modifies the default config for Access nodes to enable execution sync by default.

Operators are advised to add a flag to specify the directory where the data should be stored. e.g.
```
--execution-data-dir=/data/execution_data
```

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants