Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BN2] Update BN2 creation, deletion CI workflows #4177

Merged
merged 8 commits into from
Apr 11, 2023

Conversation

gomisha
Copy link
Contributor

@gomisha gomisha commented Apr 10, 2023

Context

This PR tweaks and finalizes the changes to BN2 CI workflows for creating and deleting Benchnet 2 networks.

This PR is made in conjunction with https://github.com/dapperlabs/flow-go/pull/6632

  • removed old way of testing new network is accessible
    • removed make k8s-expose-locally
    • removed make k8s-test-network-accessibility
    • using new way now (flow blocks get latest --host access1-<network_id>.benchnet.onflow.org:80)

ref: https://github.com/dapperlabs/flow-go/pull/6632

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #4177 (9ab7f9d) into master (bc11d79) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
- Coverage   53.61%   53.59%   -0.02%     
==========================================
  Files         848      848              
  Lines       79054    79054              
==========================================
- Hits        42382    42369      -13     
- Misses      33301    33319      +18     
+ Partials     3371     3366       -5     
Flag Coverage Δ
unittests 53.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

decreased min # of nodes
removed local k8s testing targets (k8s-test-network-accessibility, k8s-expose-locally)
changed default # of collection clusters to 1
revert back to 2 collection clusters
increase # of collection nodes to min of 2
fix if else
increased min collection nodes to 6
increase min consensus nodes to 2
added back ingress.enabled flag
reverted back to default values for COLLECTION, CONSENSUS
@gomisha gomisha force-pushed the misha/6632-bn2-update-creation-deletion-ci-workflows branch from 9ab7f9d to c7cc0c2 Compare April 11, 2023 12:13
@sjonpaulbrown sjonpaulbrown marked this pull request as ready for review April 11, 2023 19:16
@gomisha
Copy link
Contributor Author

gomisha commented Apr 11, 2023

bors merge

@bors bors bot merged commit 7490ce7 into master Apr 11, 2023
@bors bors bot deleted the misha/6632-bn2-update-creation-deletion-ci-workflows branch April 11, 2023 21:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants