-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BN2] Update BN2 creation, deletion CI workflows #4177
Merged
bors
merged 8 commits into
master
from
misha/6632-bn2-update-creation-deletion-ci-workflows
Apr 11, 2023
Merged
[BN2] Update BN2 creation, deletion CI workflows #4177
bors
merged 8 commits into
master
from
misha/6632-bn2-update-creation-deletion-ci-workflows
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4177 +/- ##
==========================================
- Coverage 53.61% 53.59% -0.02%
==========================================
Files 848 848
Lines 79054 79054
==========================================
- Hits 42382 42369 -13
- Misses 33301 33319 +18
+ Partials 3371 3366 -5
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
decreased min # of nodes removed local k8s testing targets (k8s-test-network-accessibility, k8s-expose-locally)
changed default # of collection clusters to 1
revert back to 2 collection clusters
increase # of collection nodes to min of 2
fix if else
increased min collection nodes to 6 increase min consensus nodes to 2
added back ingress.enabled flag
reverted back to default values for COLLECTION, CONSENSUS
gomisha
force-pushed
the
misha/6632-bn2-update-creation-deletion-ci-workflows
branch
from
April 11, 2023 12:13
9ab7f9d
to
c7cc0c2
Compare
sjonpaulbrown
approved these changes
Apr 11, 2023
yhassanzadeh13
approved these changes
Apr 11, 2023
bors merge |
bors
bot
deleted the
misha/6632-bn2-update-creation-deletion-ci-workflows
branch
April 11, 2023 21:14
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR tweaks and finalizes the changes to BN2 CI workflows for creating and deleting Benchnet 2 networks.
This PR is made in conjunction with https://github.com/dapperlabs/flow-go/pull/6632
make k8s-expose-locally
make k8s-test-network-accessibility
flow blocks get latest --host access1-<network_id>.benchnet.onflow.org:80
)ref: https://github.com/dapperlabs/flow-go/pull/6632