Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert Chunk structure to maintain consistent hashes #4351

Merged
merged 2 commits into from
May 15, 2023

Conversation

koko1123
Copy link
Contributor

No description provided.

Copy link
Contributor

@pattyshack pattyshack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something seems wrong here. forgot to rebase?

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit cb14878

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #4351 (98522a5) into master (0f41027) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
- Coverage   53.84%   53.81%   -0.03%     
==========================================
  Files         870      870              
  Lines       80518    80518              
==========================================
- Hits        43355    43332      -23     
- Misses      33754    33778      +24     
+ Partials     3409     3408       -1     
Flag Coverage Δ
unittests 53.81% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
model/flow/chunk.go 32.14% <ø> (ø)

... and 8 files with indirect coverage changes

@koko1123 koko1123 merged commit 0ef8623 into master May 15, 2023
@koko1123 koko1123 deleted the leo/revert-chunk-changes branch May 15, 2023 21:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants