Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFT] Compliance engine requires config #4372

Merged
merged 4 commits into from
May 29, 2023

Conversation

durkmurder
Copy link
Member

Context

As part of #4125 forced compliance engines (consensus, cluster and follower) to accept modulecompliance.Config as one of the constructor arguments. Updated usages of config to use getter function which respects the lower bound. Reason for that was that it was the optimal way to reduce boilerplate code when reading CLI flags and config creation.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #4372 (84fab08) into master (b427320) will increase coverage by 0.07%.
The diff coverage is 73.01%.

@@            Coverage Diff             @@
##           master    #4372      +/-   ##
==========================================
+ Coverage   53.75%   53.83%   +0.07%     
==========================================
  Files         871      868       -3     
  Lines       80769    80788      +19     
==========================================
+ Hits        43420    43489      +69     
+ Misses      33915    33864      -51     
- Partials     3434     3435       +1     
Flag Coverage Δ
unittests 53.83% <73.01%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/execution_builder.go 0.00% <0.00%> (ø)
cmd/scaffold.go 14.59% <0.00%> (-0.11%) ⬇️
cmd/verification_builder.go 0.00% <0.00%> (ø)
...e/common/synchronization/request_handler_engine.go 22.00% <0.00%> (-3.00%) ⬇️
fvm/environment/programs.go 58.66% <0.00%> (ø)
module/metrics/herocache.go 0.00% <0.00%> (ø)
network/alsp/internal/cache_entity.go 50.00% <ø> (ø)
network/p2p/conduit/conduit.go 0.00% <0.00%> (ø)
network/p2p/p2pbuilder/libp2pNodeBuilder.go 0.00% <ø> (ø)
engine/common/follower/compliance_engine.go 81.10% <50.00%> (-0.38%) ⬇️
... and 9 more

... and 7 files with indirect coverage changes

@durkmurder
Copy link
Member Author

bors merge

@bors bors bot merged commit 5d39cc8 into master May 29, 2023
@bors bors bot deleted the yurii/4125-compliance-engine-construction branch May 29, 2023 16:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants