-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crypto] multiple improvements of the code base #4397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/blst-based-crypto #4397 +/- ##
=============================================================
- Coverage 53.71% 53.71% -0.01%
=============================================================
Files 857 857
Lines 79948 79948
=============================================================
- Hits 42943 42941 -2
- Misses 33607 33610 +3
+ Partials 3398 3397 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple improvements of the crypto package code base. The improvements are unrelated to each other and small, they were therefore grouped in one PR:
bls12_381_utils.h
bool_t
as a C boolean type. The first version of the package C layer usedbool_t
for simplicity. This PR updates the boolean type to use the C nativebool
type assuming cgo only supports new C compilers.G1
,G2
andFr
serializations) and their respective roles in BLS signature scheme. Remove all duplicated constants.BLST_ERROR
).BLSReconstructThresholdSignature
stateless API to match the stateful API errors.