[Access] Do not return not found for tx result when collection not indexed #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4454 +/- ##
==========================================
- Coverage 54.16% 54.15% -0.02%
==========================================
Files 888 888
Lines 83743 83754 +11
==========================================
- Hits 45358 45354 -4
- Misses 34865 34884 +19
+ Partials 3520 3516 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zhangchiqing
approved these changes
Jun 9, 2023
| @@ -273,16 +277,19 @@ func (b *backendTransactions) GetTransactionResult( | |||
|
|
|||
| // access node may not have the block if it hasn't yet been finalized, hence block can be nil at this point | |||
| if block != nil { | |||
| blockID = block.ID() | |||
There was a problem hiding this comment.
we can keep this, so that only compute blockID once
| // if the request included a blockID or collectionID in its the search criteria, not found | ||
| // should result in an error because it's not possible to guarantee that the result found | ||
| // is the correct one. | ||
| if err != nil && (blockID != flow.ZeroID || collectionID != flow.ZeroID) { |
There was a problem hiding this comment.
can we simply this condition? or break it into multiple if checks? it's too complex.
koko1123
approved these changes
Jun 9, 2023
koko1123
pushed a commit
that referenced
this pull request
Jun 9, 2023
…dexed (#4454) * [Access] Do not return not found for tx result when collection not indexed * address review feedback
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was added recently to support searching for tx results by block and collection. This had a bug where if transaction was included in a block, but the block had not yet been fully indexed,
GetTransactionResultwould return aNotFounderror with the messagenot found: could not retrieve collection: key not found. Normally, the api would return a result, but the status would be pending.This PR update the endpoint to only return
NotFoundin this situation if the request include the blockID or collectionID as search criteria.