Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fix for system tx as well #4465

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Jun 10, 2023

We will need to apply the same fix as #4462 to the system tx events as well

@Kay-Zee Kay-Zee requested a review from peterargue as a code owner June 10, 2023 01:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Merging #4465 (67287ff) into v0.31 (8af7929) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            v0.31    #4465      +/-   ##
==========================================
- Coverage   54.14%   54.12%   -0.02%     
==========================================
  Files         887      887              
  Lines       83679    83679              
==========================================
- Hits        45306    45294      -12     
- Misses      34855    34866      +11     
- Partials     3518     3519       +1     
Flag Coverage Δ
unittests 54.12% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/access/rpc/backend/backend_transactions.go 49.09% <100.00%> (ø)

... and 8 files with indirect coverage changes

@Kay-Zee Kay-Zee merged commit 42ad6ea into v0.31 Jun 12, 2023
@Kay-Zee Kay-Zee deleted the kan/include-ccf-fix-for-system-tx branch June 12, 2023 20:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants