[Access] Script execution engine interface changes #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger as it doesn't need it
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 5f9c8a0 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4668 +/- ##
==========================================
- Coverage 56.25% 54.55% -1.70%
==========================================
Files 653 917 +264
Lines 64699 85898 +21199
==========================================
+ Hits 36396 46862 +10466
- Misses 25362 35439 +10077
- Partials 2941 3597 +656
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
Sep 1, 2023
zhangchiqing
approved these changes
Sep 5, 2023
| "github.com/onflow/flow-go/model/flow" | ||
| "github.com/onflow/flow-go/state/protocol" | ||
| ) | ||
|
|
||
| // ScriptExecutionState is a subset of the `state.ExecutionState` interface purposed to only access the state | ||
| // used for script execution and not mutate the execution state of the blockchain. | ||
| type ScriptExecutionState interface { |
There was a problem hiding this comment.
I think the ScriptExecutionState should go here . And since it's a subset of ReadOnlyExecutionState, we could make ReadOnlyExecutionState extends from ScriptExecutionState.
There was a problem hiding this comment.
I guess this was automatically merged. Here's another PR that makes those changes. #4685
sideninja
deleted the
gregor/script-execution/script-engine-interfaces
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4666
This PR makes sure the types used by the script execution engine are optimized so this can be reused on the access node for script execution.