Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crypto] misc updates #4681

Merged
merged 7 commits into from
Sep 6, 2023
Merged

[Crypto] misc updates #4681

merged 7 commits into from
Sep 6, 2023

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Sep 2, 2023

Protocol improvement:

  • In VSS, make sure each participant checks that the verification vector has all elements in the correct subgroup. In BLS12 381, there might be an argument that E_2 membership checks are enough, but G_2 memberships are definitely safer and consistent with the protocol description. This comes with extra performance overhead (t extra G_2 checks) for each verification vector reception.

C improvement:

  • add sanity check for type size comparisons: Flow crypto defines internal C types that should match other BLST internal C types. The size comparison explicitly checks the type matching so that future BLST versions breaking changes can be caught easily.
  • serialization macro definition improvement

Go improvement:

  • clean up cgo flags

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.43% ⚠️

Comparison is base (6bb393c) 53.70% compared to head (14c9e3d) 51.28%.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/blst-based-crypto    #4681      +/-   ##
=============================================================
- Coverage                      53.70%   51.28%   -2.43%     
=============================================================
  Files                            857      688     -169     
  Lines                          79948    61583   -18365     
=============================================================
- Hits                           42940    31584   -11356     
+ Misses                         33612    27478    -6134     
+ Partials                        3396     2521     -875     
Flag Coverage Δ
unittests 51.28% <ø> (-2.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 173 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby changed the title [Crypto] WIP [Crypto] misc updates Sep 6, 2023
@tarakby tarakby marked this pull request as ready for review September 6, 2023 18:09
@tarakby tarakby merged commit 140edc3 into feature/blst-based-crypto Sep 6, 2023
32 checks passed
@tarakby tarakby deleted the tarak/blst-misc branch September 6, 2023 18:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants