Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest stable cadence #4709

Merged
merged 21 commits into from
Sep 26, 2023
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Sep 12, 2023

@SupunS SupunS self-assigned this Sep 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage: 87.32% and no project coverage change.

Comparison is base (0e7d8c9) 55.51% compared to head (83b00fb) 55.52%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence    #4709   +/-   ##
=======================================================
  Coverage                   55.51%   55.52%           
=======================================================
  Files                         922      922           
  Lines                       85656    85648    -8     
=======================================================
+ Hits                        47553    47554    +1     
+ Misses                      34487    34481    -6     
+ Partials                     3616     3613    -3     
Flag Coverage Δ
unittests 55.52% <87.32%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/util/ledger/reporters/account_reporter.go 0.00% <0.00%> (ø)
fvm/environment/facade_env.go 97.73% <0.00%> (-0.90%) ⬇️
fvm/environment/system_contracts.go 26.49% <ø> (ø)
fvm/meter/memory_meter.go 88.88% <ø> (ø)
fvm/runtime/wrapped_cadence_runtime.go 0.00% <ø> (ø)
utils/unittest/execution_state.go 31.81% <0.00%> (ø)
engine/execution/computation/manager.go 76.36% <100.00%> (-0.63%) ⬇️
utils/unittest/service_events_fixtures.go 84.14% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS force-pushed the supun/stable-cadence branch 3 times, most recently from 40e499e to 2fe7dc6 Compare September 13, 2023 15:19
@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:feature/stable-cadence commit 16491ec

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
ComputeBlock/16/cols/128/txes/1/max-concurrency-26.36s ± 0%7.15s ± 0%~(p=1.000 n=1+1)
ComputeBlock/16/cols/128/txes/2/max-concurrency-26.68s ± 0%7.42s ± 0%~(p=1.000 n=1+1)
 
us/txdelta
ComputeBlock/16/cols/128/txes/1/max-concurrency-23.11k ± 0%3.49k ± 0%~(p=1.000 n=1+1)
ComputeBlock/16/cols/128/txes/2/max-concurrency-23.26k ± 0%3.62k ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
ComputeBlock/16/cols/128/txes/1/max-concurrency-21.88GB ± 0%2.10GB ± 0%~(p=1.000 n=1+1)
ComputeBlock/16/cols/128/txes/2/max-concurrency-21.95GB ± 0%2.13GB ± 0%~(p=1.000 n=1+1)
 
allocs/opdelta
ComputeBlock/16/cols/128/txes/1/max-concurrency-225.0M ± 0%28.6M ± 0%~(p=1.000 n=1+1)
ComputeBlock/16/cols/128/txes/2/max-concurrency-225.6M ± 0%29.3M ± 0%~(p=1.000 n=1+1)
 

@SupunS SupunS force-pushed the supun/stable-cadence branch 4 times, most recently from dd4a291 to 951e35d Compare September 13, 2023 16:27
@SupunS SupunS force-pushed the supun/stable-cadence branch 4 times, most recently from 06ddfb0 to 3a7984d Compare September 13, 2023 22:20
@SupunS SupunS force-pushed the supun/stable-cadence branch 3 times, most recently from 3ba804d to afe568c Compare September 14, 2023 21:23
@SupunS SupunS merged commit 08e9a24 into feature/stable-cadence Sep 26, 2023
36 checks passed
@SupunS SupunS deleted the supun/stable-cadence branch September 26, 2023 15:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants