[Access] Cleanup access connection management

[peterargue]

The client connection caching logic was updated to handle invalidations within a connection interceptor:

flow-go/engine/access/rpc/connection/manager.go

Lines 295 to 314 in 5c927af

	if status.Code(err) == codes.Unavailable {
	switch clientType {
	case AccessClient:
	if m.Remove(address) {
	m.logger.Debug().Str("cached_access_client_invalidated", address).Msg("invalidating cached access client")
	if m.metrics != nil {
	m.metrics.ConnectionFromPoolInvalidated()
	}
	}
	case ExecutionClient:
	if m.Remove(address) {
	m.logger.Debug().Str("cached_execution_client_invalidated", address).Msg("invalidating cached execution client")
	if m.metrics != nil {
	m.metrics.ConnectionFromPoolInvalidated()
	}
	}
	default:
	m.logger.Info().Str("client_invalidation_interceptor", address).Msg(fmt.Sprintf("unexpected client type: %d", clientType))
	}
	}

The old Invalidate* methods were left, but mostly unused outside of tests.

This PR removes those methods, fixes tests that were still using them, and fixes some other tests that were using an old version of the connection factory mock.

[peterargue]

archiveClient is using the connection manager, so this invalidation will happen automatically

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ad121db) 55.68% compared to head (effaeb7) 55.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4730      +/-   ##
==========================================
- Coverage   55.68%   55.68%   -0.01%     
==========================================
  Files         934      934              
  Lines       86532    86508      -24     
==========================================
- Hits        48188    48173      -15     
+ Misses      34707    34706       -1     
+ Partials     3637     3629       -8     

Flag	Coverage Δ
unittests	55.68% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
engine/access/rpc/backend/backend_scripts.go	67.24% <ø> (+1.00%)	⬆️
engine/access/rpc/connection/connection.go	57.14% <ø> (+2.75%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Guitarheroua]

Looks much cleaner now.