Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update state stream API to return json-cdc encoded events - backport master #4803

Merged

Conversation

peterargue
Copy link
Contributor

Closes: #4504

Backports #4533

Updates ExecutionDataAPI to use json-cdc event encoding.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (9c6f9ff) 55.80% compared to head (9660f5f) 55.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4803      +/-   ##
==========================================
+ Coverage   55.80%   55.85%   +0.05%     
==========================================
  Files         939      939              
  Lines       86922    86966      +44     
==========================================
+ Hits        48508    48578      +70     
+ Misses      34764    34720      -44     
- Partials     3650     3668      +18     
Flag Coverage Δ
unittests 55.85% <21.73%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
engine/common/rpc/convert/execution_data.go 73.36% <66.66%> (-0.30%) ⬇️
engine/access/state_stream/handler.go 38.70% <28.57%> (+38.70%) ⬆️
engine/common/rpc/convert/events.go 62.65% <0.00%> (-10.08%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Oct 6, 2023
Merged via the queue into master with commit 5e1e793 Oct 6, 2023
36 checks passed
@peterargue peterargue deleted the petera/fix-event-streaming-encoding-backport-mainnet branch October 6, 2023 18:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Execution Data APIs should use CDC-JSON encoded events
4 participants