[Storehouse - Bootstrap] Refactor checkpoint reader with WithFile #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
force-pushed
the
leo/with-file
branch
from
da4af82
to
646306b
Compare
zhangchiqing
commented
Oct 13, 2023
| if err != nil { | ||
| return fmt.Errorf("cannot read sub trie node count: %w", err) | ||
| } | ||
| nodesCount, expectedSum, err := readSubTriesFooter(f) |
There was a problem hiding this comment.
better to review these changes with "Hide Whitespace" option on:
zhangchiqing
commented
Oct 13, 2023
| if err != nil { | ||
| return fmt.Errorf("cannot read sub trie node count: %w", err) | ||
| } | ||
| nodesCount, expectedSum, err := readSubTriesFooter(f) |
There was a problem hiding this comment.
better to review these changes with "Hide Whitespace" option on
zhangchiqing
requested review from
koko1123,
sideninja,
peterargue and
fxamacker
and removed request for
ramtinms and
AlexHentschel
sideninja
reviewed
Oct 16, 2023
| @@ -738,3 +738,24 @@ func closeAndMergeError(closable io.Closer, err error) error { | |||
|
|
|||
| return merr.ErrorOrNil() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
could we add a comment explaining what it does?
sideninja
approved these changes
Oct 16, 2023
janezpodhostnik
approved these changes
Oct 16, 2023
Base automatically changed from
leo/read-trie-root-hash-from-checkpoint
to
master
October 16, 2023 21:16
zhangchiqing
force-pushed
the
leo/with-file
branch
from
592bba1
to
e9c3d8a
Compare
zhangchiqing
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a withFile function to be used for handling file opening and closing when reading checkpoint files.
Addressing review comment from #4811 (comment)