[Storehouse - Bootstrap] Validate checkpoint root hash #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4825 +/- ##
==========================================
- Coverage 55.81% 54.99% -0.82%
==========================================
Files 938 876 -62
Lines 87074 82124 -4950
==========================================
- Hits 48597 45165 -3432
+ Misses 34804 33513 -1291
+ Partials 3673 3446 -227
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Oct 17, 2023
cmd/execution_builder.go
Outdated
| @@ -1114,6 +1114,30 @@ func (exeNode *ExecutionNode) LoadGrpcServer( | |||
| ), nil | |||
| } | |||
|
|
|||
| func validateCheckpointRootHash(logger zerolog.Logger, bootstrapDir, filename string, expectedCommit flow.StateCommitment) error { | |||
There was a problem hiding this comment.
We'll need this on ANs too. can this go somewhere the AN bootstrap could access?
There was a problem hiding this comment.
I refactored in CheckpointHasRoot so that AN can reuse it
zhangchiqing
force-pushed
the
leo/validate-checkpoint-root-hash
branch
from
9fd5c32
to
6844f8f
Compare
zhangchiqing
commented
Oct 17, 2023
Comment on lines
-246
to
-247
| []*node.Node{ns[0], ns[1]}, | ||
| []*node.Node{ns[2]}, |
peterargue
reviewed
Oct 17, 2023
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
looks good. I got this working along with my changes in #4830 on localnet
koko1123
approved these changes
Oct 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zhangchiqing
changed the title
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a
CheckpointHasRootHashto be used by both AN and EN for validating that the trie hash of the root checkpoint matches with the sealed state commitment.It is useful that when bootstrapping AN or EN with pebble based register store, the checkpoint to import into pebble is matches with the root seal. We can now check using the
CheckpointHasRootHashmethod.