Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] update execution data protobuf to new namespace #4827

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

peterargue
Copy link
Contributor

Here are the related protobuf changes: onflow/flow#1353

Update the ExecutionDataAPI to use its own namespace

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (649a038) 55.81% compared to head (a02f7b8) 55.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   55.81%   55.80%   -0.02%     
==========================================
  Files         938      938              
  Lines       87074    87076       +2     
==========================================
- Hits        48597    48589       -8     
- Misses      34804    34813       +9     
- Partials     3673     3674       +1     
Flag Coverage Δ
unittests 55.80% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
engine/access/state_stream/engine.go 0.00% <0.00%> (ø)
engine/access/state_stream/handler.go 38.09% <33.33%> (-0.62%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit 6f13b8f Oct 17, 2023
36 checks passed
@peterargue peterargue deleted the petera/update-exec-data-namespace branch October 17, 2023 18:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants