Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 6.3 - Implement EVM.BridgedAccount.deploy #4897

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

turbolent
Copy link
Member

Depends on #4890

@ramtinms ramtinms changed the title [FVM] Implement EVM.BridgedAccount.deploy [FVM] beyond EVM part 6.3 - Implement EVM.BridgedAccount.deploy Nov 7, 2023
Base automatically changed from bastian/evm-withdraw to master November 14, 2023 23:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (b05bb9c) 56.23% compared to head (972fe11) 56.22%.

Files Patch % Lines
fvm/evm/stdlib/contract.go 75.00% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4897      +/-   ##
==========================================
- Coverage   56.23%   56.22%   -0.01%     
==========================================
  Files         969      969              
  Lines       90362    90410      +48     
==========================================
+ Hits        50813    50837      +24     
- Misses      35764    35786      +22     
- Partials     3785     3787       +2     
Flag Coverage Δ
unittests 56.22% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member Author

Had to skip the EVM integration test for deploying in 972fe11, as it will only start to work when proper depositing is supported.

The test will get unskipped in follow-up PR #4986, in c5030cf

@turbolent turbolent added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit ac2fa03 Nov 15, 2023
54 checks passed
@turbolent turbolent deleted the bastian/evm-deploy branch November 15, 2023 00:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants