-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Networking] Improves p2p node logging #4898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4898 +/- ##
==========================================
+ Coverage 56.19% 57.55% +1.35%
==========================================
Files 969 793 -176
Lines 90269 75520 -14749
==========================================
- Hits 50725 43462 -7263
+ Misses 35770 28777 -6993
+ Partials 3774 3281 -493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gomisha
approved these changes
Oct 30, 2023
kc1116
approved these changes
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logging of the libp2p node by pre-pending the local peer id (libp2p identifier) to the logger. This helps peer_id to flow_id translation in production.