-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Networking] Fixing enforced dial conflict between unicast manager and swarm #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhassanzadeh13
changed the base branch from
yahya/6895-fix-peer-blocking-issue
to
master
November 7, 2023 22:50
…oving-unicast-manager
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4951 +/- ##
==========================================
- Coverage 56.30% 56.21% -0.10%
==========================================
Files 963 971 +8
Lines 90184 90434 +250
==========================================
+ Hits 50776 50833 +57
- Misses 35610 35803 +193
Partials 3798 3798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kc1116
reviewed
Nov 15, 2023
kc1116
approved these changes
Nov 15, 2023
Co-authored-by: Khalil Claybon <khalil.claybon@dapperlabs.com>
peterargue
approved these changes
Nov 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update simplifies the unicast manager's operations as follows:
Reference: https://github.com/dapperlabs/flow-go/issues/6895
The following diagrams summarize the updates in the resource manger.
Unicast Manager Architecture
master
Unicast Manager Architecture
this PR