[Access] Allow all origins by default on websockets connections #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4954 +/- ##
==========================================
+ Coverage 55.74% 55.75% +0.01%
==========================================
Files 959 959
Lines 89245 89249 +4
==========================================
+ Hits 49748 49761 +13
+ Misses 35752 35740 -12
- Partials 3745 3748 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sideninja
approved these changes
Nov 8, 2023
koko1123
approved these changes
Nov 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
peterargue
added a commit
that referenced
this pull request
Nov 14, 2023
[Access] Allow all origins by default on websockets connections
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4952
This PR updates the websockets
Originheader handling to allow any origin. The default behavior requires that either theOriginheader is not set, or that it matches the host's hostname. This is inconsistent with the REST API, and breaks websockets for browser based clients unless the AN's hostname matches the URL.