Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Update RPC inspector error log #4968

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

kc1116
Copy link
Contributor

@kc1116 kc1116 commented Nov 8, 2023

Fixes inspector logs for async errors.

@yhassanzadeh13 yhassanzadeh13 changed the title Update control_message_validation_inspector.go [Networking] Update RPC inspector error log Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23c304d) 56.16% compared to head (c66b3d6) 54.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4968      +/-   ##
==========================================
- Coverage   56.16%   54.67%   -1.49%     
==========================================
  Files         966      299     -667     
  Lines       89909    26255   -63654     
==========================================
- Hits        50495    14356   -36139     
+ Misses      35656    10786   -24870     
+ Partials     3758     1113    -2645     
Flag Coverage Δ
unittests 54.67% <ø> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 669 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kc1116 kc1116 enabled auto-merge November 9, 2023 00:10
@kc1116 kc1116 added this pull request to the merge queue Nov 13, 2023
Merged via the queue into master with commit 80735b6 Nov 13, 2023
83 checks passed
@kc1116 kc1116 deleted the khalil/update-inspector-logging branch November 13, 2023 03:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants