Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch setup random source update #5088

Merged
merged 18 commits into from
Jan 18, 2024
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Nov 30, 2023

This PR is part of improving the security of the epoch source of randomness after updating the epoch core-contract (onflow/flow-core-contracts#397).

  • update the core-contract version with the latest epoch contract changes
  • node software makes sure that the source of randomness is a hex string of exactly 128 bits and rejects any other string
  • add tests for invalid sources

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (3c27e97) 55.99% compared to head (d89815f) 55.65%.

Files Patch % Lines
utils/unittest/service_events_fixtures.go 0.00% 55 Missing ⚠️
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5088      +/-   ##
==========================================
- Coverage   55.99%   55.65%   -0.35%     
==========================================
  Files         649      994     +345     
  Lines       63379    95050   +31671     
==========================================
+ Hits        35492    52900   +17408     
- Misses      25321    38177   +12856     
- Partials     2566     3973    +1407     
Flag Coverage Δ
unittests 55.65% <16.17%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby changed the title [WIP] epoch setup random source update Epoch setup random source update Nov 30, 2023
@tarakby
Copy link
Contributor Author

tarakby commented Dec 1, 2023

This PR will be open once onflow/flow-core-contracts#397 is merged

@joshuahannan
Copy link
Member

@tarakby The core contracts PR is merged and is getting upgraded on mainnet tomorrow. Does anything need to be done about this PR?

@tarakby
Copy link
Contributor Author

tarakby commented Jan 9, 2024

@joshuahannan the only constraint is to not deploy this PR on Mainnet till the contract is upgraded. This is guaranteed once the contract is upgraded so I'll open this PR tomorrow.

@tarakby tarakby marked this pull request as ready for review January 16, 2024 23:10
model/convert/service_event_test.go Outdated Show resolved Hide resolved
@tarakby tarakby added this pull request to the merge queue Jan 18, 2024
Merged via the queue into master with commit 00d5617 Jan 18, 2024
50 of 51 checks passed
@tarakby tarakby deleted the tarak/fix-epoch-setup-random-source branch January 18, 2024 21:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants