[Storehouse] Fix storage snapshot #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Dec 5, 2023
| @@ -430,8 +430,8 @@ func (e *Engine) executeBlock( | |||
| } | |||
|
|
|||
| snapshot := e.execState.NewStorageSnapshot(*executableBlock.StartState, | |||
| executableBlock.ID(), | |||
| executableBlock.Block.Header.Height, | |||
| executableBlock.Block.Header.ParentID, | |||
There was a problem hiding this comment.
This was wrong, when executing a block, the storage snapshot should be it's parent block, instead of the block itself, which has not been executed.
zhangchiqing
commented
Dec 5, 2023
| @@ -44,3 +45,23 @@ func (r *FinalizedReader) FinalizedBlockIDAtHeight(height uint64) (flow.Identifi | |||
| func (r *FinalizedReader) BlockFinalized(h *flow.Header) { | |||
| r.lastHeight.Store(h.Height) | |||
| } | |||
|
|
|||
| func (r *FinalizedReader) BlockProcessable(h *flow.Header, qc *flow.QuorumCertificate) { | |||
There was a problem hiding this comment.
not sure if there is another way to simply.
zhangchiqing
force-pushed
the
leo/fix-storage-snapshot
branch
from
c69e9fa
to
9e0560f
Compare
zhangchiqing
requested review from
koko1123,
janezpodhostnik and
sideninja
and removed request for
ramtinms
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5107 +/- ##
==========================================
+ Coverage 56.33% 59.14% +2.81%
==========================================
Files 960 662 -298
Lines 90468 55132 -35336
==========================================
- Hits 50963 32610 -18353
+ Misses 35722 20230 -15492
+ Partials 3783 2292 -1491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
koko1123
approved these changes
Dec 5, 2023
janezpodhostnik
approved these changes
Dec 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in creating the storage snapshot for ingestion engine