[Networking] Restores skipped TestGossipSubSpamMitigationIntegration
#5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
- Coverage 56.63% 56.31% -0.32%
==========================================
Files 339 976 +637
Lines 30843 91740 +60897
==========================================
+ Hits 17467 51661 +34194
- Misses 12014 36257 +24243
- Partials 1362 3822 +2460
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yhassanzadeh13
requested review from
zhangchiqing,
kc1116 and
jordanschalm
and removed request for
gomisha and
zhangchiqing
jordanschalm
approved these changes
Dec 6, 2023
tarakby
approved these changes
Dec 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yhassanzadeh13
deleted the
yahya/6915-fixing-flakey-integration-test-part-2
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reinstates the
TestGossipSubSpamMitigationIntegrationwhich was previously quarantined. The issue was addressed in PR 5095, but the test remained quarantined due to erratic CI behavior. After thorough local testing (100 consecutive passes in fail-fast mode), we've established the test's reliability. We believe the instability on CI stemmed from usingt.Parallel()in theinsecurepackage's tests. Therefore, this PR removest.Parallel()from that package and reintroduces theTestGossipSubSpamMitigationIntegration. Subsequent CI runs with this PR show no failures related to this test.