Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate flow-go/crypto #5119

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Deprecate flow-go/crypto #5119

merged 6 commits into from
Dec 11, 2023

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Dec 7, 2023

This is part migrating the crypto module out of onflow/flow-go into onflow/crypto.
This PR makes the following updates:

  • deprecate the module onflow/flow-go/crypto in favour of onflow/crypto (on go.mod)
  • the new version of onflow/flow-go/crypto will be tagged as v0.25.1 (one this PR is merged) and will be the first non-supported version.
  • update the ./crypto/Readme with deprecation details.
  • delete all source files from ./crypto to accommodate the flow-go repo (exclude flow-go/crypto from the repo testing/CI)
  • update the repo CI and Makefile by removing the crypto module related processes

Note: updating flow-go/ to use the new module onflow/crypto will be submitted in a subsequent PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (456c131) 56.31% compared to head (7f13305) 56.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5119      +/-   ##
==========================================
- Coverage   56.31%   56.29%   -0.02%     
==========================================
  Files         976      976              
  Lines       91752    91752              
==========================================
- Hits        51673    51656      -17     
- Misses      36253    36272      +19     
+ Partials     3826     3824       -2     
Flag Coverage Δ
unittests 56.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

crypto/go.mod Show resolved Hide resolved
crypto_adx_flag.mk Show resolved Hide resolved
@tarakby tarakby added this pull request to the merge queue Dec 11, 2023
Merged via the queue into master with commit 139994f Dec 11, 2023
51 checks passed
@tarakby tarakby deleted the tarak/deprecate-flow-go-crypto branch December 11, 2023 23:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants