[Storehouse] Improving logging #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Dec 9, 2023
| @@ -73,7 +73,7 @@ func (exeConf *ExecutionConfig) SetupFlags(flags *pflag.FlagSet) { | |||
| flags.StringVarP(&exeConf.rpcConf.ListenAddr, "rpc-addr", "i", "localhost:9000", "the address the gRPC server listens on") | |||
| flags.UintVar(&exeConf.rpcConf.MaxMsgSize, "rpc-max-message-size", grpcutils.DefaultMaxMsgSize, "the maximum message size in bytes for messages sent or received over grpc") | |||
| flags.BoolVar(&exeConf.rpcConf.RpcMetricsEnabled, "rpc-metrics-enabled", false, "whether to enable the rpc metrics") | |||
| flags.StringVar(&exeConf.triedir, "triedir", datadir, "directory to store the execution State") | |||
| flags.StringVar(&exeConf.triedir, "triedir", filepath.Join(datadir, "trie"), "directory to store the execution State") | |||
There was a problem hiding this comment.
the previous default value would not persist the trie data.
Use /data/trie instead of /trie by default, so that the operator doesn't have to config this flag in order to persist the trie data
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5124 +/- ##
==========================================
- Coverage 57.78% 57.69% -0.09%
==========================================
Files 799 816 +17
Lines 76991 78284 +1293
==========================================
+ Hits 44488 45169 +681
- Misses 29168 29734 +566
- Partials 3335 3381 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
requested review from
fxamacker,
janezpodhostnik,
sideninja and
peterargue
and removed request for
ramtinms and
AlexHentschel
sideninja
reviewed
Dec 11, 2023
sideninja
approved these changes
Dec 11, 2023
peterargue
approved these changes
Dec 11, 2023
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
zhangchiqing
force-pushed
the
leo/storehouse-improve-logging
branch
from
529c863
to
6314335
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Improves logging for storehouse, and also change the default trie folder path