[Dynamic Protocol State] Refactor bootstrapping and update Benchnet2 automations #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/dynamic-protocol-state #5136 +/- ##
==================================================================
+ Coverage 56.48% 56.53% +0.04%
==================================================================
Files 987 987
Lines 92531 92533 +2
==================================================================
+ Hits 52270 52315 +45
+ Misses 36414 36378 -36
+ Partials 3847 3840 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
changed the title
…tocol-state-bn-testing
jordanschalm
requested review from
durkmurder,
zhangchiqing and
AlexHentschel
and removed request for
zhangchiqing
we use the time between rootblock and finalize on Mainnet to create state commitment, speeding up spork time. Hence maintaining that structure here
commit passes bootstrapping tests, and builds on bn2
…tocol-state-bn-testing
zhangchiqing
approved these changes
Dec 15, 2023
durkmurder
approved these changes
Dec 18, 2023
jordanschalm
merged commit 5291963
into
feature/dynamic-protocol-state
53 checks passed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the bootstrapping CLI and Benchnet2 automations to be compatible with Dynamic Protocol State changes.
Changes
rootblockcommand (previously infinalize)rootblock.rootblock, but required again infinalizeis consolidated into theintermediary-bootstrapping-data.jsonfile.cmd/bootstrap/README.mdexample commands so it is again easy to manually go through the bootstrapping process using the example files committed to the repo.