Deduplicate contract names migration #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideninja
reviewed
Dec 13, 2023
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
sideninja
reviewed
Dec 13, 2023
cmd/util/ledger/migrations/deduplicate_contract_names_migration_test.go
Outdated
Show resolved
Hide resolved
sideninja
approved these changes
Dec 13, 2023
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
fxamacker
reviewed
Dec 13, 2023
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
22 tasks
janezpodhostnik
force-pushed
the
janez/deduplicate-contract-names
branch
from
6b4c3ca
to
2faa388
Compare
janezpodhostnik
requested review from
ramtinms and
AlexHentschel
as code owners
janezpodhostnik
changed the base branch from
master
to
janez/migration-infrastructure
fxamacker
reviewed
Jan 2, 2024
cmd/util/ledger/migrations/deduplicate_contract_names_migration.go
Outdated
Show resolved
Hide resolved
fxamacker
approved these changes
Jan 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add migration to deduplicate account contracts names.
extracted from: #4633
ref: #3825