[Beyond EVM] performant StateDB implementation - part 1

[ramtinms]

see #5129

[codecov-commenter]

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (38484eb) 56.49% compared to head (46dc4ce) 56.50%.

Files	Patch %	Lines
fvm/evm/emulator/state/collection.go	48.86%	115 Missing and 20 partials ⚠️
fvm/evm/emulator/state/base.go	64.87%	71 Missing and 27 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5166      +/-   ##
==========================================
+ Coverage   56.49%   56.50%   +0.01%     
==========================================
  Files         980      983       +3     
  Lines       93192    93753     +561     
==========================================
+ Hits        52649    52978     +329     
- Misses      36640    36825     +185     
- Partials     3903     3950      +47     

Flag	Coverage Δ
unittests	56.50% <58.46%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fxamacker]

Nice! I focused on non-test code and left some comments and questions.

[ramtinms]

@fxamacker any final look before I merge?

[fxamacker]

@ramtinms Nice! Looks good!

I have just a couple more questions (copied here for convenience):

• storeSlot():

  Since storeCode() removes empty code from v.cachedCodes, do we also want to remove empty slot from v.cachedSlots here for consistency?

• UpdateAccount():

  Is it possible for UpdateAccount() to be called with empty code after account was created with non-empty code? If so, does UpdateAccount() need to remove the allocated slots collection?