Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Revising RPC inspector metrics #5172

Merged
merged 17 commits into from
Dec 22, 2023

Conversation

yhassanzadeh13
Copy link
Contributor

@yhassanzadeh13 yhassanzadeh13 commented Dec 21, 2023

This PR makes these updates to RPC inspector metrics:

  1. Integrates the RPC metrics inspector with the RPC validation inspector. This unifies metrics collection, allowing more accurate and post-validation insights, such as RPC truncation and message ID types.
  2. Removes unused metrics like RPC acceptance, and adds new metrics for RPC truncation.
  3. Streamlines truncation logic, promptly failing short RPCs without unnecessary steps.

Note: The PR maintains existing metrics for backward compatibility, only modifying the addition, removal, and collection points of some metrics.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (a1b17ac) 56.48% compared to head (db107e1) 56.51%.

Files Patch % Lines
...dule/metrics/gossipsub_rpc_validation_inspector.go 0.00% 81 Missing ⚠️
...validation/control_message_validation_inspector.go 75.86% 16 Missing and 5 partials ⚠️
module/metrics/noop.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5172      +/-   ##
==========================================
+ Coverage   56.48%   56.51%   +0.02%     
==========================================
  Files         981      979       -2     
  Lines       93127    93094      -33     
==========================================
+ Hits        52602    52608       +6     
+ Misses      36632    36589      -43     
- Partials     3893     3897       +4     
Flag Coverage Δ
unittests 56.51% <35.67%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@yhassanzadeh13 yhassanzadeh13 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into master with commit 882008d Dec 22, 2023
51 checks passed
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/rpc-inspection-metrics branch December 22, 2023 18:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants