Add the EVM.encodeABIWithSignature and EVM.decodeABIWithSignature functions

[m-Peter]

These functions can be used to ABI encode/decode function calls, along with their arguments.

Example usage:

// bytes for address 0x7A58c0Be72BE218B41C608b7Fe7C5bB630736C71
let address = EVM.EVMAddress(
    bytes: [
        122, 88, 192, 190, 114, 190, 33, 139, 65, 198,
        8, 183, 254, 124, 91, 182, 48, 115, 108, 113
    ]
)

// ABI encode a function call with its arguments
let data = EVM.encodeABIWithSignature(
    "withdraw(address,uint256)",
    [address, UInt256(250)]
)

// ABI decode a function call with its arguments
// Note: We can probably infer the types with some string manipulation on the given signature
let values = EVM.decodeABIWithSignature(
    "withdraw(address,uint256)",
    types: [Type<EVM.EVMAddress>(), Type<UInt256>()],
    data: data
)

[m-Peter]

cc @turbolent @sisyphusSmiling I am not able to add you as reviewers.

[sisyphusSmiling]

Method interfaces & Cadence implementation LGTM!

[turbolent]

Looks good!

Implementing this in Cadence is nice, but also has a bit of an overhead compared to a native implementation in Go. For now this should not be a problem, but this might be worth optimizing in the future if needed.

[m-Peter]

Sounds good 👍 It shouldn't take much effort to implement them natively, if we decide to optimize things.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de63803) 56.36% compared to head (0bcb7c9) 56.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5189      +/-   ##
==========================================
- Coverage   56.36%   56.34%   -0.02%     
==========================================
  Files         994      994              
  Lines       94848    94848              
==========================================
- Hits        53461    53443      -18     
- Misses      37416    37434      +18     
  Partials     3971     3971              

Flag	Coverage Δ
unittests	56.34% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[turbolent]

It seems like one of the tests fails, indicating the state commitment changes. I think this is because the EVM contract changed, and as it is deployed when bootstrapping, it influences the state commitment?

@ramtinms Can you please confirm?

[m-Peter]

Ah, I see, I wasn't aware of that. Good point 👍