Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Optimize header ID calculation in get events #5214

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

peterargue
Copy link
Contributor

Closes: #5200

Header.ID calculations were using up a sizeable amount of resources in the get events handler. This PR updates the endpoint to cache the calculations for the duration of the request.

Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@peterargue peterargue added this pull request to the merge queue Jan 9, 2024
Merged via the queue into master with commit c5cf716 Jan 9, 2024
51 checks passed
@peterargue peterargue deleted the petera/optimize-access-events-headers-backport branch January 9, 2024 20:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Remove unnecessary calls to header.ID() in get events endpoints
3 participants